Etienne Millon

Results 216 comments of Etienne Millon

That's a good point. To a large extent this is due to the fact that this behavior is controlled through globals set via `Common`, so we can't really fix it...

Thanks @rgrinberg - I'll merge once CI passes.

Ah, that's great. Can you try #6215? I'm not super familiar with these stubs but there's definitely something wrong with memory management in there.

I agree there's something wrong going on. For example, the following fails on a clean dune checkout with csexp installed: `dune build -p dune-configurator`. Can you try to run `rm...

That would be appreciated. I can guide you but I don't have a mac handy at the moment so I can't easily work on it.

I bisected and I confirm that it's the cause. The scenario I bisected is: - checkout a dune version - install it - build and install csexp using it -...

The right way is to remove the vendored directories after unpacking the tarball (in `post-extract` if I understand correctly). `csexp` is packaged separately and has its own tarball - the...

Hi, > for real? do you hate us This kind of message is not welcome here. I'm going to refer you to [the OCaml Code of Conduct](https://github.com/ocaml/code-of-conduct/blob/main/CODE_OF_CONDUCT.md): *be friendly and...

I don't think that the lexer changes are useful for this change. Just changing `Escape` will fix the formatter, which was the original issue. The parsing error for `%{...}` will...

Thanks. I'll adapt the API so that it's more in line with the stdlib API and thus easier to remove later.