vaul icon indicating copy to clipboard operation
vaul copied to clipboard

data-vaul-no-drag on parent element not working with input fields

Open Poylar opened this issue 10 months ago • 6 comments

its about this issue https://github.com/emilkowalski/vaul/pull/267 this solution still not working with input field.if you place data-vaul-no-drag on input element it work fine, but this not work when parent element has data-vaul-no-drag attribute I've reproduced it here link

Poylar avatar Apr 09 '24 15:04 Poylar

@Poylar pretty sure the fix wasnt part of the release 0.9.0, they should release soon together w/ other fixes

maiconcarraro avatar Apr 09 '24 17:04 maiconcarraro

I have a similar issue. I am using MonacoEditor/react. When I drag to select the text inside it the drawer slides together. I inspected and noticed that all the lines inside the Monaco Editor are

tags. Even if I wrap arroud a
around the Monaco Editor it still sliding.

Shoudn`t it not drag the Vaul if a parent of it is with "data-vaul-no-drag" ?

lucarampi avatar Apr 09 '24 21:04 lucarampi

Shoudn`t it not drag the Vaul if a parent of it is with "data-vaul-no-drag" ?

@lucarampi there is a merged fix for this https://github.com/emilkowalski/vaul/pull/267

We are only waiting for a new release bump

maiconcarraro avatar Apr 09 '24 21:04 maiconcarraro

Im sorry, now I see. I though #267 was on 0.9 already, My bad.

@maiconcarraro is there some release date in your mind? So I can keep checking for updates;

lucarampi avatar Apr 09 '24 21:04 lucarampi

@lucarampi I'm not a maintainer, I mean "we" as part of the people that are waiting for the next release, I noticed Emil merged a few PRs days ago, hopefully it's going to be soon

maiconcarraro avatar Apr 10 '24 02:04 maiconcarraro

Opened an issue to bump npm version: #319

franzwilhelm avatar Apr 10 '24 10:04 franzwilhelm