egui icon indicating copy to clipboard operation
egui copied to clipboard

Fix virtual keyboard on wasm

Open micmonay opened this issue 1 year ago • 2 comments

Hello,

I have made several corrections to stabilize the virtual keyboard on Android and IOS (Chrome and Safari).

I don't know if these corrections can have a negative impact in certain situations, but at the moment they don't cause me any problems. I'll be happy to answer any questions you may have about these fixes. These fixes correct several issues with the display of the virtual keyboard, particularly since update 0.28, which can be reproduced on the egui demo site. We hope to be able to help you.

Thanks a lot for your work, I'm having a lot of fun with egui :)

micmonay avatar Jul 21 '24 04:07 micmonay

Hello,

I have carried out several tests of my own and they all seem to work. Do you need me to make any other corrections or do you have any other questions?

Thanks again for your library

micmonay avatar Aug 02 '24 05:08 micmonay

@emilk do you think you could give this another review? I'm trying to hackily copy text_agent behavior into bevy in https://github.com/mvlabat/bevy_egui/pull/279 and this change would help.

v-kat avatar Aug 18 '24 00:08 v-kat

  • Needs a rebase (and retest!) on top of https://github.com/emilk/egui/pull/4848

emilk avatar Aug 26 '24 07:08 emilk

Hello, I think I need to create a new PR with the latest version of egui and apply the necessary corrections. Since I don't think I've done the rebase correctly, I'm not quite sure of the best way to proceed.

micmonay avatar Aug 26 '24 15:08 micmonay

You should be able to fix this branch with git rebase master -i and selecting only the relevant commits, or undo your rebase and do a merge instead

emilk avatar Aug 26 '24 15:08 emilk

I think I succeeded, I'm sorry for the amount of commits and the repetition of texts... :/ I've tested the last commit, it seems OK. The script check went through. I'm not very proficient with GIT outside the basics, but I'll do better next time. Let me know if I need to make any other corrections.

micmonay avatar Aug 26 '24 16:08 micmonay

I tested it again now, and on iOS Safari it now works great. Awesome work!

emilk avatar Aug 27 '24 07:08 emilk