egui icon indicating copy to clipboard operation
egui copied to clipboard

For keep the border so we know where `TextEdit` exists.

Open rustbasic opened this issue 1 year ago • 5 comments

For keep the border so we know where TextEdit exists.

rustbasic avatar Mar 27 '24 02:03 rustbasic

Can you show an before-and-after image of the default egui style with this change?

emilk avatar Mar 30 '24 18:03 emilk

This is the image I posted before. There is a lrectangle line in the input section at the end. It would be better to know that TextEdit exists.

By the way, can I use ui.visuals().widgets.noninteractive.bg_Stroke?

Before :

explain20240313-1

After :

explain20240312

rustbasic avatar Mar 31 '24 02:03 rustbasic

Seeing screenshots of your heavily customized app is not helpful.

This is what I'm interested in:

Before this PR: Screenshot 2024-04-21 at 11 59 24

After this PR: Screenshot 2024-04-21 at 11 58 58

Now I understand what the change is. I can see the benefits (better readability) and the downsides (its uglier)

emilk avatar Apr 21 '24 10:04 emilk

Seeing screenshots of your heavily customized app is not helpful. => Sorry about that. but, I don't have enough time to even edit images.

There are pros and cons, but I think the advantage of knowing that TextEdit exists there is greater.

rustbasic avatar Apr 21 '24 10:04 rustbasic

Let's make it an option - this should be up to the user to chose

emilk avatar Apr 21 '24 17:04 emilk