egui icon indicating copy to clipboard operation
egui copied to clipboard

Update `image` crate to 0.25

Open emilk opened this issue 1 year ago • 5 comments

To not produce duplicating deps in Rerun (https://github.com/rerun-io/rerun/pull/5280) I suggest we wait with merging this until these crates have updated to image 0.25:

emilk avatar Mar 11 '24 19:03 emilk

There are some comments in code and README:s that one may want to update as well.

oscargus avatar Mar 12 '24 10:03 oscargus

  • arboard has this: https://github.com/1Password/arboard/pull/142
  • and gltf has this merged recently, just no release with it yet: https://github.com/gltf-rs/gltf/pull/414

Meanwhile, over at Ruffle we jumped the gun with https://github.com/ruffle-rs/ruffle/pull/15634, causing a missing logo image...: :/ image

torokati44 avatar Mar 24 '24 16:03 torokati44

Both of the downstream PRs have been merged now, so this now only has to wait for a new release of each crate to be published.

torokati44 avatar Apr 09 '24 21:04 torokati44

arboard v3.4.0 is now out.

torokati44 avatar Apr 29 '24 06:04 torokati44

Referencing: https://github.com/gltf-rs/gltf/pull/420

torokati44 avatar May 10 '24 10:05 torokati44

And gltf v1.4.1 is out! :tada:

torokati44 avatar May 10 '24 12:05 torokati44

Is there anything I could do to help getting this in (and a new release with it out), or is it just a matter of time to actually do it?

torokati44 avatar May 13 '24 10:05 torokati44

A new release of the egui crates won't happen for another few weeks

emilk avatar May 13 '24 11:05 emilk

Thank you for the merge! That's fine, we can wait.

torokati44 avatar May 13 '24 11:05 torokati44

@emilk since this upgrade some of my jpeg images are no longer loading properly. I suspect it is this bug in image/upstream, as they changed jpeg decoders in 0.25:

Certain JPEGs cause assertion failure in zune-jpeg

Is it possible to downgrade for now?

UPDATE: Ok after updating my own crates to 0.25.1 it appears to be working ok. Apologize for the false alarm!

jazzay avatar May 19 '24 20:05 jazzay