egui icon indicating copy to clipboard operation
egui copied to clipboard

Make `Table` min/max_scroll_height Optional by default

Open LeonardMH opened this issue 2 years ago • 5 comments

Changes the TableScrollOptions to use Optional values for min_scroll_height and max_scroll_height, requiring the user to call the respective builder functions if they desire those behaviors.

This addresses the surprising effect that by default Tables limit themselves to a maximum height of 800px (#3114).

Closes https://github.com/emilk/egui/issues/3114.

LeonardMH avatar Jun 27 '23 04:06 LeonardMH

I saw the contributing guideline to not open the PR from my master branch and assumed I would be able to edit it after opening the PR but I guess I can't. I have created a separate branch bugfix/tables-have-bounded-height-by-default in my fork if you'd rather work from that.

LeonardMH avatar Jun 27 '23 04:06 LeonardMH

Need to update the relevant documentation / comments.

LeonardMH avatar Jun 27 '23 15:06 LeonardMH

This will match how ScrollArea works, so I guess it makes sense. But no need for Option, just use f32::INFINITY instead, just like ScrollArea::max_height does

emilk avatar Aug 09 '23 14:08 emilk

Check the docs for ScrollArea to see a bit more about why we have these settings.

emilk avatar Aug 09 '23 14:08 emilk

Converted to draft awaiting progress

emilk avatar Jan 07 '24 09:01 emilk