egui icon indicating copy to clipboard operation
egui copied to clipboard

Update to winit 0.27.1 and glutin 0.29.0

Open budde25 opened this issue 1 year ago • 3 comments

Bumps winit version

budde25 avatar Aug 01 '22 05:08 budde25

Blocked on:

  • https://github.com/gfx-rs/wgpu/pull/2918

emilk avatar Aug 01 '22 08:08 emilk

This closes #992 btw.

dbuch avatar Aug 01 '22 18:08 dbuch

A new wgpu release isn’t due until late September, so either we wait until then or we make egui-winit compatible with both old and new winit, with a feature-flag to select which one to use

emilk avatar Aug 04 '22 10:08 emilk

I might have a solution to this: https://github.com/rust-windowing/winit/pull/2418

So this way Winit would implement the old and new raw_window_handle traits which can hopefully make Winit 0.27 compatible with wgpu 0.13

It would be good to test this egui branch against this

rib avatar Aug 10 '22 17:08 rib

I might have a solution to this: rust-windowing/winit#2418

So this way Winit would implement the old and new raw_window_handle traits which can hopefully make Winit 0.27 compatible with wgpu 0.13

It would be good to test this egui branch against this

I tested it, and it works! I added this to the root Cargo.toml:

[patch.crates-io]
winit = { git = 'https://github.com/rib/winit/', branch = 'raw_window_handle_04' }

and could then run egui_demo_app with the wgpu feature. Nice job @rib !

So this PR is now blocked on https://github.com/rust-windowing/winit/pull/2418 plus a winit release.

emilk avatar Aug 10 '22 17:08 emilk

ah, cool, thanks for testing/confirming

rib avatar Aug 11 '22 00:08 rib

Winit 0.27.2 got released.

kchibisov avatar Aug 12 '22 10:08 kchibisov

For some reason I can no longer push to this, so I continued the work in https://github.com/emilk/egui/pull/1914

emilk avatar Aug 14 '22 14:08 emilk