Emil Ernerfeldt

Results 813 comments of Emil Ernerfeldt

Thanks! No, I am not using this crate myself and I don't have the time to work on it. If you want to make a PR, I'll certainly review it.

@Brandontam29 does this fix it for you: ```diff --- a/crates/egui-winit/Cargo.toml +++ b/crates/egui-winit/Cargo.toml @@ -76,7 +76,7 @@ serde = { version = "1.0", optional = true, features = ["derive"] } webbrowser...

The problems are the `unwrap`s here: https://github.com/Smithay/smithay-clipboard/blob/858419b586c679dedd46f5347c26b19a7e00c56b/src/worker.rs#L95-L98 Make a PR to `smithay-clipboard` to replace those `unwrap`s, and replace them with `state.reply_tx.send(Err(err))` or a log line. Any takers?

Are both the `glow` and `wgpu` backends affected?

The API is not supported on winit on Mac: https://docs.rs/winit/latest/winit/window/struct.Window.html#method.set_window_icon You'll need to make a PR to winit to fix it!

Well… it's both/either, I guess. I would love it if winit supported icons on Mac and Windows, but since it doesn't, we have this in eframe: https://github.com/emilk/egui/blob/4c8b95f365983582ccb7a97a29bafeecd7f4d6bc/crates/eframe/src/native/app_icon.rs And yes, that...

`egui_plot` has recently been moved to its own repository, at https://github.com/emilk/egui_plot This will hopefully speed up its development by having more reviewers and maintainers. Please re-open this PR at https://github.com/emilk/egui_plot/pulls...

Great questions! Anyone is welcome to help review PRs, in order to provide feedback and help the PR author. Of course, someone with merge rights will still have the final...