Emilio Cobos Álvarez comments

Results 779 comments of


                                            Emilio Cobos Álvarez

Have some easy way to #[allow(non_camel_case_types)] (or even do it by default)

Yeah I think raw-line is more flexible and already a thing.

Pass the kind of item to `ParseCallbacks::item_name`

Seems sensible.

[Feature Request] Allow the addition of custom Rust annotations to generated function definitions

We have already a `wasm_import_module_name` option that adds such an attribute where you want, afaict. Extending / generalizing that seems better. Given we merge the blocks I think it'd be...

handle more cases of packed and aligned structs when it's safe/correct

I'd take a reasonable patch for this, sure :)

handle more cases of packed and aligned structs when it's safe/correct

> So I think to support this, it might make sense to try to move the logic to check if "align" is explicitly needed into an earlier stage, maybe somewhere...

Undefined/redefined C macro keeps old value

Is it? It's hard to say what version of a redefined macro should be generated IMO... But yeah, I guess the latest one seems reasonable. My `bindgen/ir/var.rs` is what handles...

Inappropriate generated type for function-returning-function

Interesting. We're reading stuff from libclang, but IIRC there were some quirks with how we get the right function type.

Cannot override integer type of constified enum module.

That's kind of intentional, because functions taking a `node_kinds` would need to accept a c-int (would break the ABI otherwise).

Cannot override integer type of constified enum module.

Same for structs containing it or what not. Thus, not clear it's a bug, would be rather dangerous to do as proposed. But please reopen if you disagree or I've...

Cannot override integer type of constified enum module.

reopening as per the above though I still think it'd be rather footgunny.