Emilio Cobos Álvarez

Results 777 comments of Emilio Cobos Álvarez

`cbindgen` when ran on `build.rs` could potentially run `rustc -Z syntax-only` or something to provide a nicer error, but...

I expect the simplest solution if you want to do it from `build.rs` would be to create a crate that depends on the crate that you want to run cbindgen...

hmm, we should definitely document and test our MSRV. If you send a PR to fix that I'd be happy to merge it and release it as 0.14.3 if you...

Yeah, that's silly. Should be trivial to fix, let me know if you're blocked on it or need it fast and I should be able to fix quick.

Hmm, a bit edge case-y. `PrimitiveType::maybe` seems to special-case these names, but I'm a bit confused as of why, since the input is supposed to be a rust type, not...

Ah, blaming it seems this was added in https://github.com/eqrion/cbindgen/pull/130 (without tests :/). `libc::int8_t` and so on are deprecated, maybe removing those particular special cases is sensible (though there's a few...

So there are two issues here: * `Type::simplified_type` is kind of naive, and doesn't handle well generic aliases. * `Type::is_repr_ptr` doesn't deal very well with aliases either. This is due...

This probably needs a bit of work on cbindgen's side to fix, but it should not be too terrible, at the very least for easy cases... What probably needs to...

That is UB, and probably the null check will be optimized away in release builds.

> defining the "optional callback" as a separate typedef makes it so the function signature is not available in the headerfile, I tried defining an extra type like this: That's...