Emilio Cobos Álvarez

Results 777 comments of Emilio Cobos Álvarez

Ok, so I know why this one happens, but I don't know what are we supposed to generate there? I can't think of a valid way to translate that in...

Yeah, this is a failure during parsing. We try to have a consistent view of the world before generating code... Oh well, C++, you win this time. I can't work...

On Wed, Jan 11, 2017 at 01:24:31AM -0800, Nick Fitzgerald wrote: > Or maybe we can try to properly track everything in parsing and ir and > then emit opaque...

Huh, fun. Thanks for the reduced test-case, that's awesome! And sorry you hit this bug :( We're overflowing the stack here: ``` #48539 0x0000555555921c58 in bindgen::ir::comp::CompInfo::layout (self=0x555556048570, ctx=0x7ffffffea598) at src/ir/comp.rs:1115...

Sorry for the delay here. We could probably define a few standard macros in BindgenContext::parsed_macros, if we wanted to fix this.

There's no guarantee that generally `u16` is a typedef to `uint16_t` tho, right? I guess we could add some sort of special-casing but...

@nt1m / @rniwa, do you know the status of this in WebKit? I recall seeing some patches in flight to implement this long ago, but it doesn't seem to work,...

So, there seemed to be consensus today on doing this at some point during update the rendering. I sent a patch updating the tests here: https://bugzilla.mozilla.org/show_bug.cgi?id=1788741 However, that uncovers a...

Oh, I somehow missed that mention... But the answer is "Gecko's innerText impl was a bit bogus", see https://github.com/web-platform-tests/wpt/issues/12580.

> Revising the focusability criteria seems reasonable to me, but I'd like to to be as well-defined as possible. Moving from "has CSS boxes" to "has any visible/interactible parts" seems...