Emi

Results 458 comments of Emi

I'm going to mark this as WontFix -- but leave the issue open. I currently think that it is not possible to implement this in a way that truly works...

Agreed, we should be producing a clean panic here and documenting this or refusing to accept `vecty.Attribute` here via the type-system instead. `vecty.Text` is just a DOM TextNode, essentially, so...

Yeah, or we could always offer an `vecty.KeyedText` if it is really needed in the future. 👍 to just changing signature to `vecty.Text(text string)`

@bzub Could you elaborate / provide examples of `Applyer`s that you make yourself?

I think this is probably more a documentation issue. If you're getting such panics, it means you're violating a core principle of Vecty. That should be happening very rarely. This...

Sounds great to me! I think maybe my original message must have sounded dismissive? That was not my intent, I was just trying to explain why I thought docs are...

Another thought: there was a linter planned that would catch such problems (passing a component to another as a field without a prop tag)

> I was wondering if you'd accept an issue on adding it to vecty/* || hexops/* once it's sorta fleshed out. See discussion in https://github.com/hexops/vecty/issues/188 - in general, I don't...

Also note the RenderSkipper interface allows a component to decide for itself if rerendering should not occur: https://pkg.go.dev/github.com/hexops/vecty#RenderSkipper