mora icon indicating copy to clipboard operation
mora copied to clipboard

Builds failing due to missing goproperties repo

Open GUI opened this issue 9 years ago • 3 comments

I'm trying to build mora in a new environment, but it's failing because it looks like the emicklei/goproperties repository has been deleted from github: https://github.com/emicklei/goproperties Was this intentional? I think I was building successfully last month when I thinks this repo still existed.

$ go get
# cd .; git clone https://github.com/emicklei/goproperties /tmp/gocode/src/github.com/emicklei/goproperties
Cloning into '/tmp/gocode/src/github.com/emicklei/goproperties'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

I found the original upstream repo at dmotylev/goproperties, so I'm not sure if mora could be switched over to use that directly, or if there was relevant changes in your forked repo that are needed.

Thanks!

GUI avatar Jul 16 '15 16:07 GUI

oops, deleted while thinking i didn't use it anymore. Most other projects are using the properties package of frank schroder. sorry about this mistake. At the moment i am on a 3wk holiday with limited access. Maybe you are willing to create a PR for this?

emicklei avatar Jul 17 '15 14:07 emicklei

ps the pkg i was referring to is magiconair/properties

emicklei avatar Jul 18 '15 08:07 emicklei

No worries or rush on your holiday. Thanks for the pointer on the magiconair/properties library. I've submitted a pull request using that library instead, and that seems to be working for my purposes. Thanks!

GUI avatar Jul 18 '15 15:07 GUI