dslabs icon indicating copy to clipboard operation
dslabs copied to clipboard
verified publisher icon emichael

Migrate from numeric primitive times to Instant/Duration

Open emichael opened this issue 2 years ago • 7 comments

We should be using Instant and Duration from the java.time package instead of millisecond times stored as longs or ints.

emichael avatar May 12 '23 18:05 emichael

Hi, I am new to open source and would love to help out. Could you provide me with more information regarding where in the codebase these changes need to be made?

ChrisPerezLebron avatar May 12 '23 18:05 ChrisPerezLebron

@emichael any further information? i am done with cloning the repo which classes do I have to work on? image

AsfarHorani avatar May 12 '23 22:05 AsfarHorani

@emichael Please assign it to me

AsfarHorani avatar May 12 '23 22:05 AsfarHorani

/assign

AsfarHorani avatar May 12 '23 23:05 AsfarHorani

Hi, Asfar and Chris. Thanks so much for the offer to help! This is really something I want someone who's already done the labs and is familiar with the codebase to tackle, though.

emichael avatar May 13 '23 00:05 emichael

Ahh that's really sad. I saw the good first issue tag and i wanted to contribute. If u get some time u can explain me code base for a while.

AsfarHorani avatar May 13 '23 00:05 AsfarHorani

@emichael if there's any other issue i can work on please let me know thanks

AsfarHorani avatar May 13 '23 00:05 AsfarHorani