lein-cljsbuild icon indicating copy to clipboard operation
lein-cljsbuild copied to clipboard

Add support for Nashorn & Node.js repls.

Open levand opened this issue 9 years ago • 3 comments

Code for all three "embedded" REPLs is now in a single namespace.

This required upgrading the Clojure and ClojureScript versions used for development and testing, which also required upgrading Midje and lein-midje.

Test updates are included, though I could not get the tests to run properly in the plugin project - I am not sure how they could run given the current state of the code. Midje seems to bail early instead of acknowledging an expected error. Tests in support pass correctly.

Documentation is also included

levand avatar Mar 06 '15 19:03 levand

I want this to be merged!!

crocket avatar Oct 05 '15 11:10 crocket

@crocket this kind of comment comes across as unhelpful. Everybody working or contributing on cljsbuild (and most open source projects) are doing it as a gift for the community. If you're interested in seeing it merged, then a polite :+1: would probably suffice. Open source burnout is a real thing, and these kinds of comments contribute to it.

danielcompton avatar Oct 05 '15 19:10 danielcompton

@levand Happy to merge this. I don't mind doing a manual merge to resolve the conflicts, or would you want to resolve the conflicts yourself?

mneise avatar Oct 11 '15 00:10 mneise