lein-cljsbuild
lein-cljsbuild copied to clipboard
Expose hooks for build started/stopped
In the same vein as #370 , it would be nice to have notification hooks on build started/stopped. It would make it possible to easily integrate @tonsky's https://github.com/tonsky/AnyBar, etc.
Opening an issue to make sure this would be acceptable before writing the patch.
Sounds fine, although :notify-command
is already the "build stopped" hook, yes?
Well, for status notifier to work, it’s better to have explicit different
callbacks on “build finisher without warnings”, “build finisher with
warnings”, “build haven’t finished”. As far as I remember,
:notify-command
is not called if e.g. you have syntax error if a file.
If you just have hooks on build start/stopped, and separate hook on warning, you cannot write notifier: build stopped, but you don’t know its status. You have to keep state somewhere (warning hook was called between start hook and stop hook), which complicates things a lot
On Tue, Mar 3, 2015 at 2:17 AM Chas Emerick [email protected] wrote:
Sounds fine, although :notify-command is already the "build stopped" hook, yes?
— Reply to this email directly or view it on GitHub https://github.com/emezeske/lein-cljsbuild/issues/375#issuecomment-76806832 .