Eimi Okuno

Results 18 comments of Eimi Okuno

Hey @bevand10, do you have any thoughts on this? :)

Hi @iaditya! > In my project, I end up having multiple instances. Browser like Safari would not work properly in canvas goes more than 10. I'm not familiar with Safari...

Also, weirdly maybe unrelated - I'm seeing a gap in progress bar when progressing further into the video.

A very good catch, the re-renders definitely don't happen for the original master. vs this branch: `onChange` and `handleKeyCommand` makes the Editor re-render.

https://github.com/facebook/react/issues/16437#issuecomment-524892514 The original highlighting function has disappeared but instead you can use the profiler to record the rendering.

Added back the Editor as a memoized react component, and now the re-renders are gone.

@gittes - hi! Thanks for sending us a request to improve the adapters - we would be ecstatic if you could help us out to add that compatibility, based on...

Hi @ddugovic - thanks for reaching out. Will look into open sourcing this :) In the meantime, I recommend you fork it, and will keep you posted on getting it...

https://github.com/bbc/digital-paper-edit-firebase as part of https://github.com/bbc/digital-paper-edit-firebase/issues/1