emersion
Crosshairs
This is based on https://github.com/emersion/slurp/pull/56, but has been rebased on master, and fixed some issues I found while testing (mostly around outputs that don't start at the origin).
When moving the crosshairs between monitors, sometimes this happens:
https://user-images.githubusercontent.com/20397027/136587209-404f481f-5ef8-42b8-8def-31ed37cb14d5.mp4
When moving the crosshairs between monitors, sometimes this happens:
That's unfortunate. I'm not entirely sure why that happens. Reverting 0eeba3ae32eaecc2c36a6bfb5df363880c9adf91 fixes, it. That does mean we mark the outputs as dirty more often than necessary. I'd have to investigate more to see if there is a better way to handle that.
By the way do you have merge permissions or does this still require @emersion's approval first?
I have merge permissions, but I would like it to be reviewed by someone else before merging.
Reverting 0eeba3a fixes, it. That does mean we mark the outputs as dirty more often than necessary. I'd have to investigate more to see if there is a better way to handle that.
Any luck with this? Or perhaps this could still be shipped since it doesn't seem like a showstopper, especially since crosshairs are not enabled by default.
No, I haven't investigated it any more yet. (But the revert is on this branch).
Ok, I think I've got better checks on when to mark outputs as dirty now. I was just missing a condition in an if statements one of the places where seat_set_outputs_dirty was called.
I've been using this locally for a while from a manual build and I've been super happy with it. Thanks for putting it together @tmccombs!
