mako icon indicating copy to clipboard operation
mako copied to clipboard

No blur

Open lilydjwg opened this issue 2 years ago • 9 comments

This should fix #387.

lilydjwg avatar Nov 23 '21 07:11 lilydjwg

The CI failure seems to be unrelated, complaining a build option I didn't touch.

lilydjwg avatar Nov 23 '21 07:11 lilydjwg

Works for me too, thanks for the PR! Hoping this will get merged soon :)

kabouzeid avatar Dec 03 '21 15:12 kabouzeid

Ping @emersion

jplatte avatar Apr 09 '22 21:04 jplatte

The issue has been less problematic lately; the first notification is only blurry for an instant and then it quickly unblurs. I think this has been [partially/mostly] fixed.

This PR has conflicts now tho.

WhyNotHugo avatar May 24 '22 15:05 WhyNotHugo

I've removed all other commits and rebased the de-flickering commit on master.

lilydjwg avatar Jul 01 '22 12:07 lilydjwg

This commit doesn't make sense to me. It works fine when there is only one screen, but breaks as soon as there are multiple.

emersion avatar Jul 01 '22 13:07 emersion

Oops. I'll try to fix it when I get access to my other screen.

lilydjwg avatar Jul 01 '22 13:07 lilydjwg

I don't think it's possible to fix without a Sway change to send the wl_surface.enter event before the layer-surface is mapped.

emersion avatar Jul 01 '22 13:07 emersion

Hi, I rebased my commit and tested it on my setup. Yes it would be nicer if we could receive an enter enter before the surface is mapped, but I think this is a good-enough workaround for me.

I have two monitors, one is the laptop's internal screen and the other is an external 4K monitor. I mostly work on the external one while I put some informational windows on the laptop's one, so for the most of time notifications will appear on the external one, i.e. it doesn't switch between multiple outputs.

The issue I have is that, the first frame of mako is not only blurry but also has a different size (it seems to be accumulated difference of text height). This patch makes it not "jump" when it re-appears on the same output.

lilydjwg avatar Jul 19 '22 14:07 lilydjwg