mako icon indicating copy to clipboard operation
mako copied to clipboard

scan-build cleanup + allocation fail handling

Open Ongy opened this issue 4 years ago • 6 comments

This is based on https://github.com/emersion/mako/pull/228

First commit unique to this PR cleans up 3 possible memory leask detected via scan-build.

Second commit sprinkles couple of allocation failure handlers into the code. Though I don't think there's a system with a reasonable use for mako that doesn't use overcommit and actualy allows to have an allocation failure.

Ongy avatar Apr 28 '20 18:04 Ongy

This has a bunch of extra commits from your other PR.

vilhalmer avatar Apr 28 '20 22:04 vilhalmer

(It occurs to me I don't actually know if github allows you to represent a PR based on another…)

vilhalmer avatar Apr 28 '20 22:04 vilhalmer

Converted to a draft to make it clear this shouldn't be merged before #228

emersion avatar Apr 29 '20 10:04 emersion

Not really. Github allows to have PRs into PRs, but that's then not tracked on the main repo.

I don't think there's a built-in feature for PR based on PR. Draft sounds good :)

Ongy avatar Apr 29 '20 10:04 Ongy

Needs rebase

emersion avatar Jun 23 '20 11:06 emersion

There's still a couple of strdup() and maybe some of the pango functions left out. If we also want to check them, I'll add them as well, but I feel like this makes things considerably harder to read, witch questionabe value (non-overcommit systems with graphics are rare these days).

Ongy avatar Jun 30 '20 15:06 Ongy

Closing because this is too old/outdated. Please re-open a new PR if you want to work on this again!

emersion avatar Dec 26 '23 20:12 emersion