mako icon indicating copy to clipboard operation
mako copied to clipboard

Add a way to ignore notifications

Open emersion opened this issue 5 years ago • 4 comments

Add a way to drop notifications matching some criteria.

I think @AN3223 is interested in this.

emersion avatar Jun 08 '19 19:06 emersion

It would also be interesting to turn off or silence notifications completely (e.g. when in a meeting). Something like:

$ makoctl disable [--until ...]

# later...
$ makoctl enable

When combined with history (see #91) this could be really neat, as enable could trigger a notification of its own saying something like "Notifications enabled: 42 missed notifications (use history command to view)".

matt-snider avatar Jul 02 '19 19:07 matt-snider

For this, see https://github.com/emersion/mako/issues/138

emersion avatar Jul 02 '19 19:07 emersion

I have a issue with an app which sents a notificication, and when I click the notification, someone will receive a notification, which will then create another notification. Is there any way to ignore the notification, besides, having to kill mako and launch it again?

Jpfonseca avatar Jun 03 '20 11:06 Jpfonseca

Send a patch implementing this feature ;)

emersion avatar Jun 03 '20 11:06 emersion

I'd like to get this feature to ignore some rather spammy notifications from Plover. Here's what I do now:

on-notify=exec pw-cat --playback /usr/share/sounds/freedesktop/stereo/message.oga

[app-name=Plover body~="Wayland does not support QWindow::requestActivate\(\)"]
invisible=1
on-notify=dismiss

This almost works, with the only (at least as far as I can tell) caveat that mako stores these dismessed notifications in history. What I'm imagining to fix this is adding a new value for on-notify (and probably for the other on-* events) called delete (bikeshedding on name welcome) that would delete the notification entirely.

What do you think? I'm up for sending a patch if you think this idea looks good.

triallax avatar Sep 25 '23 11:09 triallax

I think I'd prefer something like ignore=1 rather than an on-notify hook.

emersion avatar Oct 02 '23 13:10 emersion

That's fine with me too, I'll send a PR when I get the chance.

triallax avatar Oct 02 '23 14:10 triallax

I opened a PR https://github.com/emersion/mako/pull/477, reviewing and/or testing would be appreciated.

triallax avatar Oct 02 '23 15:10 triallax