libliftoff icon indicating copy to clipboard operation
libliftoff copied to clipboard

Skip setting properties that haven't changed

Open emersion opened this issue 5 years ago • 1 comments

~~Atomic test-only commits set property values for the next commit when they succeed.~~ We don't need to keep setting the same property values over and over again.

emersion avatar Dec 20 '19 13:12 emersion

Atomic test-only commits set property values for the next commit when they succeed.

Nope, that's false. Was confused because wlroots re-used the atomic requests between commits.

Only regular commits set property values for subsequent commits.


Another thing to keep in mind is that a VT switch messing up our previous state may happen at any time. Also there's no guarantee the compositor has performed a regular atomic commit after liftoff_output_apply.

emersion avatar May 22 '20 10:05 emersion