hydroxide icon indicating copy to clipboard operation
hydroxide copied to clipboard
verified publisher icon emersion

Add attachemt signature support

Open dvalter opened this issue 5 years ago • 5 comments

Fix error 15197 for encrypted messages with attachments.

Use additional pipe in crypto.symmetricallyEncrypt to pass signature from the encryption code to the attachment structure as a buffer.

Fixes #31

P.S. I'm not Go developer, so this PR may contain some dirty code. I'm not happy with some solutions myself, especially with signature as buffer, but if I straight away use the same approach as with ContentID or other string fields, Protonmail can't accept this signature and returns Signature: null in POST response.

dvalter avatar Mar 03 '20 00:03 dvalter

are there plans to merge this PR?

natask avatar Oct 13 '20 06:10 natask

Thanks for your wonderful work! I'm very looking forward to seeing this PR merged! 👍

aurelg avatar Jan 30 '21 07:01 aurelg

sounds good to me with the last fix from @dvalter , what do you think @emersion ?

ValHeimer avatar Jun 18 '21 07:06 ValHeimer

@emersion Is there any plan to get this merged?

abrattic avatar May 25 '22 08:05 abrattic

G'day, lads! Cheers for your hard work, it is sincerely appreciated! How far along is this PR? :)

deetuned avatar Oct 18 '22 23:10 deetuned