hydroxide icon indicating copy to clipboard operation
hydroxide copied to clipboard

Published 20 hours ago • verified publisher icon emersion

Fix messages operation exceeding page limit

Open proletarius101 opened this issue 4 years ago • 3 comments

Fixes #119

proletarius101 avatar Dec 27 '20 17:12 proletarius101

This potentially sends a lot of requests in parallel. The ProtonMail API has limits and may send a 420 response.

emersion avatar Jan 06 '21 13:01 emersion

This potentially sends a lot of requests in parallel. The ProtonMail API has limits and may send a 420 response.

... Well that's a lot. 84000 messages totally. I have only 40000 messages for more than 10 years. So most people won't face such upper bound. Do you suggest to run this sequentially instead?

It might be a large number for Protonmail. But wouldn't ProtonMail API's thorttling be enough to defend this kind of "attack"? So for Protonmail's side I believe it's acceptable. The only problem is it may still raise errors, although much better than the 1 response of 200 messages limit.

proletarius101 avatar Jan 06 '21 14:01 proletarius101

When will this be merged?

microo8 avatar Jun 01 '21 11:06 microo8