go-smtp icon indicating copy to clipboard operation
go-smtp copied to clipboard

Published 20 hours ago • verified publisher icon emersion

Add client and server support for SMTP DSN extension

Open foxcpp opened this issue 4 years ago • 2 comments
trafficstars

Breaking change since it changes Client.Rcpt and Session.Rcpt signature.

Closes #32.

foxcpp avatar Jan 22 '21 15:01 foxcpp

Do you have plans to add basic test cases for these new features?

emersion avatar Jan 29 '21 16:01 emersion

Do you have plans to add basic test cases for these new features?

Yeah, they should be added.

foxcpp avatar Jan 30 '21 15:01 foxcpp

Hi,

I just wrote a DSN extension also: https://github.com/emersion/go-smtp/compare/v0.18.0...ikedas:go-smtp:dsn_extension

I think my code is better in the following respects:

  • It includes the fix for PR #232 (conversely, this should be merged first).
  • Takes into account the case where SMTPUTF8 extension is enabled (update by RFC6533).
  • Doesn't include breaking changes to currect release.

Should I submit a separate PR?

ikedas avatar Sep 03 '23 03:09 ikedas

Please feel free to submit a new PR, yeah.

Do note that we can still do breaking changes to our API if we feel that they are worth it.

emersion avatar Sep 07 '23 01:09 emersion

Superseded by #233

emersion avatar Nov 03 '23 09:11 emersion