go-imap icon indicating copy to clipboard operation
go-imap copied to clipboard

Published 20 hours ago • verified publisher icon emersion

Added MYRIGHTS and SETACL support

Open opsxolc opened this issue 6 months ago • 1 comments

opsxolc avatar Feb 15 '24 10:02 opsxolc

This is part of the IMAP4 ACL extension.

emersion avatar Feb 15 '24 10:02 emersion

It seems like a vendor/ dir was committed?

emersion avatar Mar 04 '24 10:03 emersion

Also I'd prefer to avoid the testify dependency if possble…

emersion avatar Mar 04 '24 10:03 emersion

Sorry, I keep getting more comments for new functionality...

I would suggest trying to upstream your patches step by step if you want me to merge stuff more quickly. That is, stop adding more features and functions, focus on addressing the review comments. But if you are fine with getting continuous feedback for new ACL functions, that's fine by me as well. I don't want you to be frustrated because of the feedback, is all.

I can also help addressing the review comments if you grow tired of it.

emersion avatar Mar 04 '24 10:03 emersion

Hey! I'm drowning in work right now, but I'll be back with fixes as soon as I can. I really want to contribute to this project)

opsxolc avatar Mar 15 '24 10:03 opsxolc

No worries, take your time :)

emersion avatar Mar 15 '24 10:03 emersion

So builds.sr.ht failed due to the issue with ACL extension support as I mentioned in a thread above

opsxolc avatar Apr 23 '24 12:04 opsxolc

The error message from CI is:

    acl_test.go:74: create MyFolder.Child error: imap: NO [CANNOT] Character not allowed in mailbox name: '.' (0.001 + 0.000 secs).

By default Dovecot uses . for mailbox delimiters. a3d367456797a4cf1a9c853ba0e7d75dff67f069 changes it to / (to align it with imapmemserver).

emersion avatar May 14 '24 07:05 emersion

The client parts have been merged in #618, still missing the server part from this PR.

emersion avatar May 16 '24 11:05 emersion