node-gravatar icon indicating copy to clipboard operation
node-gravatar copied to clipboard
verified publisher icon emerleite

Gravatar refactor

Open lukasaric opened this issue 6 years ago • 10 comments

This PR refactors gravatar packet into ES6 and also polishes code.

lukasaric avatar Jun 12 '19 10:06 lukasaric

👌 Very nice!

zcuric avatar Jun 14 '19 06:06 zcuric

Actually, this solves #44 and #41. 👍

zcuric avatar Jun 14 '19 06:06 zcuric

@emerleite ping :)

zcuric avatar Jun 26 '19 09:06 zcuric

Hey guys, sorry for the delay. Can you wait til the weekend to the review? I'll generate a new version using your contribution.

Thanks :)

emerleite avatar Jun 27 '19 18:06 emerleite

Sure, take your time 👍

PS As @zcuric already mentioned this resolves #44 & #41 🎉

vladimyr avatar Jun 27 '19 18:06 vladimyr

This PR will also fix vulnerability https://bugzilla.redhat.com/show_bug.cgi?id=1623744 generated by yargs > os-locale > mem and fixed with yargs > 13.0.0.

PorresM avatar Aug 31 '19 07:08 PorresM

Perfect @PorresM. Sorry for the delay. I'll try to check this weekend.

emerleite avatar Sep 11 '19 14:09 emerleite

any update? would be nice to support this as rollup -c doesnt support current version when using es6

northkode avatar Sep 29 '19 14:09 northkode

Ping.

zcuric avatar Oct 21 '19 20:10 zcuric

Hey guys, do you know if this PR fixes this vulnerability: https://npmjs.com/advisories/1500

Also @emerleite would it be possible to get this PR reviewed? I personally would love to see this PR merged.

bvallelunga avatar May 01 '20 07:05 bvallelunga