node-gravatar icon indicating copy to clipboard operation
node-gravatar copied to clipboard

[Suggestion] Refactor to ES6

Open lukasaric opened this issue 6 years ago • 5 comments

Refactor this packet to JavaScript ES6?

lukasaric avatar May 16 '19 19:05 lukasaric

For sure. Can u send a PR? Thanks !!!

emerleite avatar Jun 08 '19 00:06 emerleite

@emerleite I could create a PR including TypeScript support and es5/es6 bundles.What do you think about that?

danielsogl avatar Jun 11 '19 20:06 danielsogl

For sure. Can u send a PR? Thanks !!!

Need permission to push origin PR. Please, give me access and I will send a PR :bowtie: .

lukasaric avatar Jun 12 '19 09:06 lukasaric

@lukasaric you don't need access to create a PR. You have to fork the repo and create a new branch from master.

danielsogl avatar Jun 12 '19 10:06 danielsogl

@emerleite I could create a PR including TypeScript support and es5/es6 bundles.What do you think about that?

Done. But I'm pretty much typescript n00b so please take a look on what I did here: #45

vladimyr avatar Jun 14 '19 23:06 vladimyr