OpenSubtitlesDownload
OpenSubtitlesDownload copied to clipboard
emericg
Password storage
Just as the title suggests, it would be nice if the program can store the login credentials (say in ~/.config/somedir/filerc). The command line having all the details, which can also be seen via ps is a problem.
In principle I agree, but looking at the nature and purpose of this programme, plus the duration it takes to run, I would argue that any system you run this on and it being a security risk, you shouldn't be running it there?
That being said, I just edit the script with username/password, but it's very mildly annoying to have to do git stash before every pull to retain the credentials (ie. sometimes I forget), which wouldn't be any problem if we'd use a configuration file, so I support your request for a different reason.
sidenote: be sure to execute the script with 2 spaces in front, so it won't show up in your history file for others to find either.
I think storing the credentials in a separate file wouldn't be a more secure solution than storing them in the script like right now. But I can agree that at least it would be more practical. But because the script doesn't have a config file anyway... There might be a simple solution for those who really want to put that in a separate file anyway, I'll try to figure something out.
The right solution would be to use the OS to securely store those in a wallet, but I really don't know if that's possible in a cross plateform way, and without dependency (or possible at all).
