dshackle icon indicating copy to clipboard operation
dshackle copied to clipboard

I don't think role: fallback is working correctly anymore

Open MysticRyuujin opened this issue 4 years ago • 4 comments

I am using Infura and a few other providers with role: fallback and disable-validation: true but I'm seeing a lot of queries being sent to these nodes despite the fact that my local (non-fallback) nodes are operating just fine.

image

MysticRyuujin avatar Apr 11 '21 15:04 MysticRyuujin

In the same time frame over on Alchemy I've got this: image

I think disable-validation: true is working, based on the API calls being sent, but role: fallback seems to not be honored here.

MysticRyuujin avatar Apr 11 '21 15:04 MysticRyuujin

👋

MysticRyuujin avatar Apr 19 '21 12:04 MysticRyuujin

Hi @MysticRyuujin, sorry for the delay. I believe it's honored actually. I also use Infura as a backup and I see a dramatic drop of requests stat when role: fallback is enabled.

Though I agree it still makes more requests that it should. It seems it fetches a block data once Dshackle sees block header through websockets. In this case it the request usually go to a first upstream that produced that notification, and that may be fallback node. Also it seems there are few other cases when an internal request may go to a fallback upstream directly. I'm going to improve those parts.

splix avatar Apr 23 '21 03:04 splix

Ah, so it's likely the WebSocket notifications causing most of it. Good to know. I can just disable that on the quotad providers! I could go back test, but I'll leave it alone 🙂

MysticRyuujin avatar Apr 23 '21 03:04 MysticRyuujin