dshackle icon indicating copy to clipboard operation
dshackle copied to clipboard

Add support for Fantom

Open MysticRyuujin opened this issue 4 years ago • 5 comments

In a previous PR you added this: CHAIN_FANTOM = 102; // Fantom, https://fantom.foundation/

But these lines were missing. Fantom calls their chain opera sometimes too, so I added opera as an option as well.

MysticRyuujin avatar Aug 21 '21 01:08 MysticRyuujin

I assume this, like the previous PR needs to have upstream dependencies fixed?

EDIT: Actually, it looks like this PR worked. I built it and am running:

2021-20-08 20:21:03.277 | INFO  |          Multistream | State of FTM: height=15104576, status=OK/3,SYNCING/1, lag=[0, 0, 0, 9]

MysticRyuujin avatar Aug 21 '21 01:08 MysticRyuujin

Nope, something is still wrong with FTM support. It seems to get stuck where the height never increases, even though the nodes are in sync.

MysticRyuujin avatar Aug 21 '21 01:08 MysticRyuujin

Codecov Report

Merging #103 (feba1b5) into master (64d667a) will decrease coverage by 0.02%. The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     52.58%   52.55%   -0.03%     
  Complexity      793      793              
============================================
  Files           152      152              
  Lines          5131     5137       +6     
  Branches        747      749       +2     
============================================
+ Hits           2698     2700       +2     
- Misses         2035     2038       +3     
- Partials        398      399       +1     
Impacted Files Coverage Δ
.../dshackle/upstream/calls/DefaultEthereumMethods.kt 55.14% <0.00%> (-2.15%) :arrow_down:
...emeraldpay/dshackle/startup/ConfiguredUpstreams.kt 20.68% <100.00%> (+1.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64d667a...feba1b5. Read the comment docs.

codecov-commenter avatar Aug 30 '21 01:08 codecov-commenter

Thank you! It seems that I need to check why it stuck. This time I'm not ready for setting up another node, so I'm going to try with their public RPC. Will let you know

splix avatar Aug 30 '21 01:08 splix

Ok, so the Fantom doesn't have conception of "Block Difficulty" which Dshackle uses to determine forks/consensus splits. As a result Dshackle cannot figure out if a new block is a really new (i.e., a new head).

It's unclear how to deal with Fantom in this aspect :(

splix avatar Aug 30 '21 22:08 splix