wand icon indicating copy to clipboard operation
wand copied to clipboard

`pyproject.toml` missing in git repo (but present in sdist tarball)

Open mgorny opened this issue 7 months ago • 5 comments

The Wand-0.6.12.tar.gz sdist on PyPI contains a pyproject.toml but said file isn't present in the git repo. Could you add it, please?

That said, I've noticed because I wanted to submit a fix for two problems:

  1. The wheel dependency is unnecessary (see https://github.com/pypa/setuptools/commit/f7d30a9529378cf69054b5176249e5457aaf640a).
  2. You need to explicitly do something like sys.path.insert(0, ".") before importing files relative to the package directory when using the modern setuptools backend, otherwise it may be unable to import wand.version (depending on PEP517 frontend invocation). (Alternatively, you can use more modern setup.cfg/pyproject.toml approach for getting version from file that doesn't require importing it; see: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html or https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#dynamic-metadata).

Of course, I can submit PRs for these once the file's in the repo.

mgorny avatar Nov 03 '23 17:11 mgorny