embulk icon indicating copy to clipboard operation
embulk copied to clipboard

embulk --version with -X gem_home

Open hiroyuki-sato opened this issue 1 year ago • 3 comments

Issue Type: Bug Report

  • Write the following environmental information.
    • OS version: macOS 13.2.1
    • Java version: 1.8
    • Embulk version: 0.10.48

The following command outputs gem_home is set as a sub directory of embulk_home: /Users/user/.embulk/lib/gems even -X gem_home=/tmp/gem_home set. It's a little confusing.

java -jar ~/.embulk/bin/embulk-0.10.48  -X gem_home=/tmp/gem_home --version
Embulk 0.10.48
2023-04-13 14:59:48.457 +0900 [INFO] (main): m2_repo is set as a sub directory of embulk_home: /Users/user/.embulk/lib/m2/repository
2023-04-13 14:59:48.460 +0900 [INFO] (main): gem_home is set as a sub directory of embulk_home: /Users/user/.embulk/lib/gems
2023-04-13 14:59:48.460 +0900 [INFO] (main): gem_path is set empty.
2023-04-13 14:59:48.460 +0900 [DEBUG] (main): Embulk system property "default_guess_plugin" is set to: "gzip,bzip2,json,csv"

hiroyuki-sato avatar Apr 13 '23 06:04 hiroyuki-sato

Thanks for filing this. About it, what is the key point of the problem? The log is different from the -X option? The real gem home setting is different from the -X option? Such logs are printed even for just --version? I was not sure what is the main point.

dmikurube avatar Apr 17 '23 06:04 dmikurube

Thank you for your comment.

  • gem install outputs gem_home properly.
  • embulk -version and embulk -help outputs default path even I set -X gem_home explicitly. (These outputs confuse me.)

Proposal change

  • Plan A: Remove embulk_home path in embulk -version and embulk -help
  • Plan B: Output correct gem_home path.

embulk -version

java -jar /pat/to/embulk/embulk-0.10.49 -X gem_home=/tmp/gem_home -version
Embulk 0.10.49

2023-04-17 17:14:52.366 +0900 [INFO] (main): gem_home is set as a sub directory of embulk_home: /Users/user/.embulk/lib/gems

embulk -help

java -jar /pat/to/embulk/embulk-0.10.49 -X gem_home=/tmp/gem_home -help
Usage: embulk [common options] <command> [command options]

...
2023-04-17 17:16:02.775 +0900 [INFO] (main): gem_home is set as a sub directory of embulk_home: /Users/user/.embulk/lib/gems

embulk gem install

java -jar /pat/to/embulk/embulk-0.10.49 -X gem_home=/tmp/gem_home gem install embulk


2023-04-17 17:13:37.561 +0900 [INFO] (main): gem_home is set from command-line: /tmp/gem_home
...
Successfully installed embulk-0.10.49-java

hiroyuki-sato avatar Apr 17 '23 08:04 hiroyuki-sato

Got it. Agreed that they need to be consistent even with --version and --help. Let me have a look.

dmikurube avatar Apr 17 '23 08:04 dmikurube