Support embulk util retryhelper jetty version 94
Which issue this PR resolve for? The new JVM uses TLS 1.3 as default, but Jetty 92 and Jetty 93 don’t support TLS 1.3.
How this PR resolve this issue?
- Replace embulk-util-retryhelper-jetty92 by embulk-util-retryhelper-jetty94
- Refactor the import path from jetty92 to jetty94
- Update dependencies lock:
From
org.eclipse.jetty:jetty-client:9.2.14.v20151106=compileClasspath,runtimeClasspath
org.eclipse.jetty:jetty-http:9.2.14.v20151106=compileClasspath,runtimeClasspath
org.eclipse.jetty:jetty-io:9.2.14.v20151106=compileClasspath,runtimeClasspath
org.eclipse.jetty:jetty-util:9.2.14.v20151106=compileClasspath,runtimeClasspath
To
org.eclipse.jetty:jetty-client:9.4.51.v20230217=compileClasspath,runtimeClasspath
org.eclipse.jetty:jetty-http:9.4.51.v20230217=compileClasspath,runtimeClasspath
org.eclipse.jetty:jetty-io:9.4.51.v20230217=compileClasspath,runtimeClasspath
org.eclipse.jetty:jetty-util:9.4.51.v20230217=compileClasspath,runtimeClasspath
There was the same PR, we did before: https://github.com/embulk/embulk-util-retryhelper/pull/11
Ah, one thing. Please update this part as well.
https://github.com/embulk/embulk-output-elasticsearch/blob/65ad90c9f8b60988cfe1c783a790ed0bd900bcdd/NOTICE_GEM#L13-L14
Hi @dmikurube ,
I have updated NOTICE_GEM and CHANGELOG.md.
Thank you
Hi @dmikurube ,
Please help me to approve workflows.
Regards,
Approve which workflows?
Approve which workflows?
Hi @dmikurube ,
Sorry for late response, as the document: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
When an outside contributor submits a pull request to a public repository, a maintainer with write access may need to approve any workflow runs.
As, I checked the workflow has been run:
So, you can ignore my previous comment.
Hi @dmikurube ,
Please help me merge & release this PR.
Thank you,
Other pull requests are merged. It's time to go. Thanks for working on it!