embrace-android-sdk icon indicating copy to clipboard operation
embrace-android-sdk copied to clipboard

Added typeMappings and languageSpecificPrimitives to avoid full imports

Open priettt opened this issue 11 months ago • 2 comments

Added typeMappings and languageSpecificPrimitives to avoid classes with full import paths (like kotlin.String and kotlin.collections.Map)

This doesn't work with List, it's probably a problem in the generator. I tried having a look at the source code but it's a mess 😅

priettt avatar Mar 13 '24 17:03 priettt

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

  • #562 Graphite 👈
  • #553 Graphite
  • #552 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @priettt and the rest of your teammates on Graphite Graphite

priettt avatar Mar 13 '24 17:03 priettt

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.08%. Comparing base (bfd867a) to head (21555a6).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           codegenNameMapping     #562      +/-   ##
======================================================
- Coverage               80.19%   80.08%   -0.11%     
======================================================
  Files                     412      412              
  Lines                   10986    10986              
  Branches                 1617     1617              
======================================================
- Hits                     8810     8798      -12     
- Misses                   1532     1544      +12     
  Partials                  644      644              

see 7 files with indirect coverage changes

codecov[bot] avatar Mar 13 '24 17:03 codecov[bot]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

github-actions[bot] avatar Jun 07 '24 01:06 github-actions[bot]

This PR was closed due to inactivity.

github-actions[bot] avatar Jun 17 '24 01:06 github-actions[bot]