embrace-android-sdk icon indicating copy to clipboard operation
embrace-android-sdk copied to clipboard

Replace data with envelopeData to avoid quotes in the class

Open priettt opened this issue 11 months ago • 2 comments

Added nameMappings in openApiGenerate to avoid the data property in Envelope looking like this:

val `data`: EnvelopeData

priettt avatar Mar 12 '24 20:03 priettt

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

  • #562 Graphite
  • #553 Graphite 👈
  • #552 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @priettt and the rest of your teammates on Graphite Graphite

priettt avatar Mar 12 '24 20:03 priettt

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.19%. Comparing base (82e5f46) to head (bfd867a).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           openApiCodeGen     #553      +/-   ##
==================================================
+ Coverage           80.15%   80.19%   +0.03%     
==================================================
  Files                 412      412              
  Lines               10986    10986              
  Branches             1617     1617              
==================================================
+ Hits                 8806     8810       +4     
+ Misses               1535     1532       -3     
+ Partials              645      644       -1     

see 2 files with indirect coverage changes

codecov[bot] avatar Mar 12 '24 20:03 codecov[bot]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

github-actions[bot] avatar Jun 07 '24 01:06 github-actions[bot]

Closing as stale

fractalwrench avatar Jun 17 '24 09:06 fractalwrench