react-canvas-draw icon indicating copy to clipboard operation
react-canvas-draw copied to clipboard

LoadSavedData - Treat as a transaction

Open ish-joshi opened this issue 5 years ago • 2 comments

Realtime support

I was attempting to build a real time drawing board using Firebase database when I realised something very strange.

I am using the onChange handler to be notified of any updates so that they can be written to the database.

Once new data is received, it is passed to the component to be re-drawn. As it redraws each line, the onChange is triggered for each line, which causes an infinite loop.

What do the creators/maintainers think about treating the whole loadSaveData() as a transaction; after all lines are drawn the change notification is published. I already have made changes to the existing library and tested to make sure it works.

Check out this fork (https://github.com/ish-joshi/react-canvas-draw) and I'm happy to raise a PR if maintainers/contributors agree with the approach.

ish-joshi avatar Jul 13 '20 23:07 ish-joshi

I am doing the same thing in my app, and I just dont update the database while loadSaveData is running

HenryLeC avatar Nov 27 '20 17:11 HenryLeC

Seems like a bug to me tbh. If you'd still be interested to create a PR, then please do so.

Otherwise I'll pull the changes from your fork.

Thanks for reporting this!

embiem avatar Nov 07 '21 22:11 embiem