kubernetes-reflector icon indicating copy to clipboard operation
kubernetes-reflector copied to clipboard

Feature Request: Reflect object labels

Open jarett-cyxtera opened this issue 3 years ago • 9 comments

Hello,

Would it be possible to reflect the labels from the source secrets/configmaps along with the data? I'd try to add this feature myself, but I'm not at all familiar with C#.

Thanks!

jarett-cyxtera avatar Jan 14 '22 21:01 jarett-cyxtera

That's a very interesting but also dangerous request :)

It would have to be a separate flag entirely because labels are used in lookups and having this enabled by default is VERY problematic.

But nice feature and I'll add it as soon as I can.

winromulus avatar Jan 14 '22 21:01 winromulus

Understood - thanks!

Our use cases:

  • We have some services that use labels to dynamically select multiple secrets.
  • We're using Argo CD, and have found that mirrored secrets are always identified as orphaned resources even though the source is labeled appropriately.

jarett-cyxtera avatar Jan 14 '22 22:01 jarett-cyxtera

Automatically marked as stale due to no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 04:04 stale[bot]

Not stale

mvoitko avatar Apr 21 '22 07:04 mvoitko

Removed stale label.

stale[bot] avatar Apr 21 '22 07:04 stale[bot]

Automatically marked as stale due to no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 13 '22 01:06 stale[bot]

Not stale

mvoitko avatar Jul 06 '22 20:07 mvoitko

Removed stale label.

stale[bot] avatar Jul 06 '22 20:07 stale[bot]

Automatically marked as stale due to no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 09:08 stale[bot]

I'm not sure if we want all labels reflected. I'm considering this feature but there would have to be a control mechanism. Not sure if regex or starts-with.

winromulus avatar Mar 06 '23 09:03 winromulus

Removed stale label.

stale[bot] avatar Mar 06 '23 09:03 stale[bot]

Include/exclude lists might be reasonable option as well.

jarett-cyxtera avatar Mar 07 '23 14:03 jarett-cyxtera

This would be an incredibly useful feature for us as well.

Use Case: in tightly controlled ArgoCD environments, I cannot deploy to the argocd namespace. However, the repository and repository secrets need to live in that namespace. I was successful in using Reflector to get the secret from my "customer" namespace to the argocd namespace, but due to labels not being replicated ArgoCD can't identify it as a repository.

danmanners avatar Dec 08 '23 16:12 danmanners

This would be an even more useful feature if it were decoupled from the secret/CM realm.

At the moment, there is no operator that could reflect some labels/annotations from one object to another, and that is sometimes extremely valuable.

crabique avatar Jan 16 '24 17:01 crabique