rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Remove ember-cli-dependency-checker

Open NullVoxPopuli opened this issue 2 years ago • 3 comments
trafficstars

fewer dependencies = better?

NullVoxPopuli avatar Sep 22 '23 16:09 NullVoxPopuli

I've found this package helpful in two scenarios recently:

  1. I forgot to run pnpm install
  2. I set an override in my package.json and forgot to update the actual specified dependency version to match.

wagenet avatar Sep 22 '23 16:09 wagenet

I've added those scenarios to the RFC.

  1. is mostly covered, I think? you get a pretty early error otherwise 2. there is another use case here where your dependencies are stale.
  2. this is uncovered

maybe instead of removing this dependency across the board, we

  • don't include it in embroider projects (webpack / vite tooling can check versions and probably provide better UI for seeing dep version mismatches -- i need to see if something for this already exists though -- because I feel like it should)
  • move ember-cli-dependency-checker into the ember-cli org, and keep it for classic apps

NullVoxPopuli avatar Sep 22 '23 16:09 NullVoxPopuli

+1 to callout from @wagenet as not once it helped to avoid mistakes by not running npm i/pnpm i

SergeAstapov avatar Sep 22 '23 18:09 SergeAstapov