Advance RFC #0649 "Deprecation Staging" to Stage Ready for Release

[emberjs-rfcs-bot]

trafficstars

Advance #0649 to the Ready For Release Stage

Rendered RFC

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

• PR to Accepted Stage: #0649

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

• [ ] Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
• [ ] Any necessary learning materials have been updated
• [ ] The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
• [ ] Criteria for moving to the Recommended Stage has been filled out
• [ ] This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
• [ ] Each team has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
  • Framework @emberjs/framework
  • Data @emberjs/ember-data-core
  • CLI @emberjs/cli
  • Learning @emberjs/learning-core
  • Typescript @emberjs/typescript-core
  • Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

Track Implementation

<-- Use this section to track implementation of the RFC -->

[ef4]

Latest update here is that parts of this are implemented but not all, and someone needs to review the RFC and status and figure out the remaining bits.

[wagenet]

I will try to give this a look, though if someone else wants to hop in here, please do.

[ef4]

This still needs a champion to review the status. This was a relatively old RFC that predates our current process.

[ef4]

At the end of the RFC review we spent some time re-reading this RFC. The changes to deprecate already happened (and the old usage was already removed at 4.0). The addon configuration piece remains to be done, but doesn't seem too hard. Next meeting we will make some time to fill out the todo list.

[ef4]

The addon configuration piece remains to be done, but doesn't seem too hard.

This fully-automatic addon configuration turns out to not be very easy and nobody has expressed interest in working on it right now.

A higher priority remaining task would be to make a way to actually turn on the available-but-not-yet-enabled deprecations.

[ef4]

We discussed a simplified update to the RFC that would put this into config/environment.js instead of package.json (given that it is runtime info). This will be nice to have in the runup to 6.0.