Advance RFC #0830 "Evolving Ember's Major Version Process" to Stage Ready for Release

[emberjs-rfcs-bot]

Advance #0830 to the Ready For Release Stage

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

• PR to Accepted Stage: #0830

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

• [ ] Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
• [ ] Any necessary learning materials have been updated
• [ ] The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature
• [ ] Criteria for moving to the Recommended Stage has been filled out
• [ ] This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
• [ ] Each team has been added as a reviewer to the PR at the start of the FCP
  • [ ] Framework @emberjs/framework
  • [ ] Data @emberjs/ember-data-core
  • [ ] CLI @emberjs/cli
  • [ ] Learning @emberjs/learning-core
  • [ ] Typescript @emberjs/typescript-core
  • [ ] Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

1. Document for developers how to add a deprecation and test/flag it.

Track Implementation

<-- Use this section to track implementation of the RFC -->

• [ ] Should the release policy go in Release.md? It contains some info about our typical release train. Anywhere on the website?
• [ ] Document the major version process on https://emberjs.com/releases/
• [x] Introduce new tooling to Ember's internal tests which simulate the mode in which the deprecation fails. (We already have some of this, but need to iterate on it.) https://github.com/emberjs/ember.js/pull/20669
• [x] Require that all new deprecations test both the deprecated and non-deprecated paths, so we can be confident that removing the deprecation will not cause test failures. (This was an issue in the run up to 4.0.) https://github.com/emberjs/ember.js/pull/20669
• [ ] When releasing a major, the deprecations will be disabled automatically because they target that major version. Then the dead (deprecated) code paths can be removed incrementally and at will, rather than it having to be removed prior to the major release.
  • [ ] Implement deprecations in Ember Cli such that they can automatically break at the major version point
  • [x] Implement deprecations in Ember source so that they automatically break at the major version point https://github.com/emberjs/ember.js/pull/20669

[ef4]

The work here is to make ember's deprecation infrastructure automatically convert warnings into errors when you cross the until boundary of a deprecation.

[ef4]

Latest update:

• ember-source feature landed
• ember-cli needs similar work