rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Always run new RFC checks so CI can pass

Open wagenet opened this issue 2 years ago • 7 comments
trafficstars

wagenet avatar Nov 23 '22 19:11 wagenet

I think there are parts of the workflow that rely upon this not running for all directories. It needs some testing.

kategengler avatar Nov 23 '22 20:11 kategengler

At least some of these items are required for CI to be green, so if we don't do this specific thing, we need to find another way to resolve it. See https://github.com/emberjs/rfcs/pull/867 for the issue.

wagenet avatar Nov 23 '22 21:11 wagenet

I think it's not unreasonable to merge PRs that don't touch RFCs without green CI, until we work this out. None of the CI jobs do anything for changes not under /text and PRs that don't change RFCs are rare.

kategengler avatar Nov 23 '22 21:11 kategengler

image

The PR section used to be browsable (for new RFCs). Now it's mostly noise.

Maybe add a label to all actual RFCs? That way the label filter can be used to get rid of the noise.

sandstrom avatar Dec 07 '22 09:12 sandstrom

@sandstrom Newly opened RFCs will have a label of S-Proposed. There are some quick links to filter the list in the README.

But, I suggest that you should also be interested in RFCs moving to Ready for Release, Released, and Recommended: advancing to these stages means the RFC is progressing and there may be changes at these later stages. There are FCPs for both Ready for Release and Recommended.

I suggest filtering to exclude PRs that are in Draft.

kategengler avatar Dec 07 '22 14:12 kategengler

Thanks @kategengler!

I noticed there is also a project overview, maybe we should link that one too from the README.md?

sandstrom avatar Dec 07 '22 15:12 sandstrom

@sandstrom I'm not sure of the status of that project. I think it may have been used to determine statuses for the backlog of RFCs. But, I am working on a dashboard.

kategengler avatar Dec 07 '22 15:12 kategengler