emberjs
Deprecate implicit record loading in Ember Route
@scottmessinger @runspired is there anything more that we need here other than an "official" review?
@wagenet this is a framework team item not a data team item though Scott did pick it up from @NullVoxPopuli it seems to try to get it over the line. I think this became of increased importance because the troll behavior lead to increased bug reports and confusion once injections were eliminated for 4.x
ah right! this supersedes https://github.com/emberjs/rfcs/pull/557 <-- I'll close this
100%. I’d be eager to do the legwork once merged if someone else didn’t pick it up. Unsure if it needs a “sponsor”. Let me know if someone can bring it up in the core team meeting!
Framework core discussed this and everyone is in favor of the deprecation.
A suggestion is that the design could use an optional feature that disables the old bad behavior. This would let people clear the deprecation by enabling the feature, rather than requiring them to create new empty model hooks and potentially new route files.
@ef4 Thanks and updated with your suggestion for the optional feature (PR). What is the process for merging this RFC?
What is the process for merging this RFC?
Core framework team needs to put it into final comment period, wait the customary week so people have a chance to comment, and then merge it.
I'll make sure it comes up at the next meeting.
@snewcomer looks like it may have gotten dropped on accident, sorry! I've officially added it to the agenda for our next meeting.
@snewcomer Sorry for the delay. Everything got thrown off with the holidays. I'll try to get this back on track.
We agreed to move this to FCP. It needs a few tweaks for our new stages setup and will need to be retargeted at v6. I can help with this.
I think this also means that the routes-segments-snake-case rule can be removed from the recommended ruleset?
I've been disabling that rule on every project I work on since we don't depend on the implicit record loading and it would be nice if we could remove it from our eslint config file 😄.
