rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Align the mount and route APIs

Open jsturgis opened this issue 4 years ago • 3 comments

This RFC describes the motivation and implementation for aligning the mount and route API signatures.

https://github.com/emberjs/ember.js/pull/19402

jsturgis avatar Feb 12 '21 08:02 jsturgis

This may be out of scope, but it feels related to https://github.com/ember-engines/ember-engines/issues/80 (though I realize the inside-out nature of this adds complexity).

meirish avatar Feb 19 '21 07:02 meirish

Is there still interest to move this forward?

wagenet avatar Jul 23 '22 23:07 wagenet

IMO we should discuss and see if it's still relevant and have some chance to be included on https://github.com/emberjs/rfcs/pull/819

cc/ @runspired @SergeAstapov

villander avatar Jul 25 '22 13:07 villander

This RFC is probably not aligned with what we want to do. It's motivation says:

Some Ember applications utilize in-repo ember-engines strictly for their lazy loading and code organization features and not for their isolation features.

Going forward, these are not relevant reasons to use engines, because we have better alternatives for both lazy loading and code organization.

  • for lazy loading, you can use import() via either ember-auto-import or embroider
  • for code organization, first-class component templates means you can use all the organization patterns that work with normal ES modules.

ef4 avatar Jan 27 '23 20:01 ef4

@SergeAstapov / @void-mAlex Do you have any thoughts on this?

achambers avatar Sep 01 '23 14:09 achambers

@achambers I strongly agree with what Ed said in previous comment and I'm not sure I see the actual problem this gonna solve as Engines by design are separate apps and they should not leak anything up to the host app.

SergeAstapov avatar Sep 01 '23 14:09 SergeAstapov

Given the fact that this is not aligned with our current direction we are moving to FCP to Close.

wagenet avatar Sep 22 '23 18:09 wagenet

Looks like no comments so this should be good to close. Will leave to the RFC #2 meeting to do so.

achambers avatar Sep 29 '23 14:09 achambers