rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Add additional info in blueprint lifecycle hooks to support 3rd-party addons to provide a way to codemod blueprints to reduce copy-pasta

Open NullVoxPopuli opened this issue 3 years ago • 2 comments

Rendered

NullVoxPopuli avatar Jan 06 '21 20:01 NullVoxPopuli

@NullVoxPopuli I assume you'd like this to get a proper review?

wagenet avatar Jul 23 '22 23:07 wagenet

Yes! for extending blueprints, I still think codemodding the output would be stellar (and is the basis behind the ember-apply* stuff

NullVoxPopuli avatar Jul 23 '22 23:07 NullVoxPopuli

I think it might make sense to close this and make this kind of extensibility a design goal for a next-gen blueprint system (something I've already been discussing with @NullVoxPopuli and others).

The problem with the existing blueprint system is that

  • it leaks a lot of ember-cli internals that we don't want to maintain forever
  • those internals are extremely expensive to instantiate so the cli commands are very slow

These are the reasons that v2 addon do not (yet) have a way of including blueprints. When we add one, we want to make sure it doesn't share these problems.

It's not clear that we even need to be maintaining our own blueprint system, nothing about it is ember-specific and if somebody wants to survey the existing tools that are out there and suggest one as the new default, we could probably design a compatibility bridge that brings most existing blueprints across.

ef4 avatar Dec 07 '22 18:12 ef4

@ef4 I'm agreed that we definitely do not want to leak ember-cli internals!

wagenet avatar Dec 07 '22 21:12 wagenet

@NullVoxPopuli Is this still relevant?

achambers avatar Aug 11 '23 14:08 achambers

I don't think so -- @mansona is leading the charge with blueprint updates

NullVoxPopuli avatar Aug 11 '23 19:08 NullVoxPopuli