rfcs
rfcs copied to clipboard
emberjs
Advance RFC #0726 `"DOM Element descriptor interface for test helpers"` to Stage Released
Advance #0726 to the Released Stage
Rendered
Summary
This pull request is advancing the RFC to the Released Stage.
- PR to Accepted Stage: #0726
- PR to Ready For Release Stage
Upon merging this PR, automation will open a draft PR for this RFC to move to the Recommended Stage.
Released Stage Summary
The work is published. If it is codebase-related work, it is in a stable version of the relevant package(s). If there are any critical deviations from the original RFC, they are briefly noted at the top of the RFC.
If the work for an RFC is spread across multiple releases of Ember or other packages, the RFC is considered to be in the Released stage when all features are available in stable releases and those packages and versions are noted in the RFC frontmatter.
Ember's RFC process can be used for process and work plans that are not about code. Some examples include Roadmap RFCs, changes to the RFC process itself, and changes to learning resources. When such an RFC is a candidate for Released, the work should be shipped as described, and the result should presented to the team with the intent of gathering feedback about whether anything is missing. If there is agreement that the work is complete, the RFC may be marked "Released" and a date is provided instead of a version.
An RFC is moved into "Released" when the above is verified by consensus of the relevant team(s) via a PR to update the stage.
Checklist to move to Released
- [ ] The work is published in stable versions of the relevant package(s), with any feature flags toggled on.
- [ ] Deviations from the original RFC are noted in the RFC
- [ ] Release packages and dates are updated in the RFC frontmatter
- [x] The dom-element-descriptors library is released
- [x] The @ember/test-helpers implementation is released in v3.3.0
- [x] The qunit-dom implementation is awaiting review, and I'm not sure what to do to push it forward
- [x] The fractal-page-object implementation is complete but not released -- I was waiting until the
qunit-domimplementation was released to merge, but I guess I should probably just merge and release
Discussion at tooling meeting today was hashing out the implementation strategy to unblock the qunit-dom feature. We have a consensus plan on a pluggable implementation in qunit-dom that meets everybody's needs.
I see that a release of qunit-dom went out, @bendemboski what remains to be released?
@ef4 nothing! I've updated the checklist above, however I'd like to hold off on declaring victory until I can update the test app in fractal-page-object to use the newly-released qunit-dom rather than patching my changes in locally, just to prove that it's all working end-to-end. I should be able to get to that very soon -- next few days certainly.
@ef4 I just release v1.0 of fractal-page-object which now gives a working end-to-end implementation of this RFC -- page objects from fractal-page-object can be passed directly to @ember/test-helpers' DOM helpers and qunit-dom's assertions.
For the last checklist item above -- (Release packages and dates are updated in the RFC frontmatter), do I open another PR into this repo to update the dates? Or what's next here?