ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

[WIP] Deprecate Evented

Open wagenet opened this issue 4 months ago • 2 comments

We still need to figure out correct deprecation ids.

https://github.com/ember-learn/deprecation-app/pull/1404

wagenet avatar Sep 04 '25 20:09 wagenet

I just realized that the approach of two mixins may not work with detect. We might be able to do what we want with a Proxy.

EDIT: A Proxy won't easily work either because we look for whether it's in a Set and the Proxy-wrapped version is not identical to the original. As annoying as this is, the best approach is probably just to have a way to temporarily disable the deprecation when used in Ember internals.

EDIT 2: I've reworked this and it should work as expected now.

wagenet avatar Sep 05 '25 03:09 wagenet

Estimated Asset Sizes

Diff

--- main/out.txt	2025-09-04 03:19:38.000000000 +0000
+++ pr/./pr-17484044865/out.txt	2025-09-05 04:53:38.000000000 +0000
@@ -1,46 +1,46 @@
 ╔═══════╤═══════════╤═══════════╗
 ║       │ Min       │ Gzip      ║
 ╟───────┼───────────┼───────────╢
-║ Total │ 418.65 KB │ 232.22 KB ║
+║ Total │ 415.84 KB │ 230.92 KB ║
 ╚═══════╧═══════════╧═══════════╝
 
-╔══════════════════════╤══════════╤═══════════╗
-║ @ember/*             │ Min      │ Gzip      ║
-╟──────────────────────┼──────────┼───────────╢
-║ Total                │ 239.4 KB │ 147.23 KB ║
-╟──────────────────────┼──────────┼───────────╢
-║ -internals           │ 35.46 KB │ 25.49 KB  ║
-║ application          │ 12.83 KB │ 7.7 KB    ║
-║ array                │ 12.66 KB │ 7.32 KB   ║
-║ canary-features      │ 304 B    │ 419 B     ║
-║ component            │ 1.07 KB  │ 1005 B    ║
-║ controller           │ 1.8 KB   │ 1.36 KB   ║
-║ debug                │ 11.4 KB  │ 7.92 KB   ║
-║ deprecated-features  │ 31 B     │ 77 B      ║
-║ destroyable          │ 561 B    │ 383 B     ║
-║ enumerable           │ 259 B    │ 387 B     ║
-║ helper               │ 823 B    │ 605 B     ║
-║ instrumentation      │ 2.43 KB  │ 1.78 KB   ║
-║ modifier             │ 669 B    │ 581 B     ║
-║ object               │ 33.78 KB │ 20.79 KB  ║
-║ owner                │ 159 B    │ 178 B     ║
-║ renderer             │ 406 B    │ 350 B     ║
-║ routing              │ 58.08 KB │ 33.43 KB  ║
-║ runloop              │ 2.2 KB   │ 1.33 KB   ║
-║ service              │ 859 B    │ 741 B     ║
-║ template             │ 430 B    │ 364 B     ║
-║ template-compilation │ 429 B    │ 366 B     ║
-║ template-compiler    │ 57.91 KB │ 30.4 KB   ║
-║ template-factory     │ 94 B     │ 160 B     ║
-║ test                 │ 923 B    │ 627 B     ║
-║ utils                │ 3.93 KB  │ 3.5 KB    ║
-║ version              │ 55 B     │ 131 B     ║
-╚══════════════════════╧══════════╧═══════════╝
+╔══════════════════════╤═══════════╤══════════╗
+║ @ember/*             │ Min       │ Gzip     ║
+╟──────────────────────┼───────────┼──────────╢
+║ Total                │ 236.59 KB │ 145.9 KB ║
+╟──────────────────────┼───────────┼──────────╢
+║ -internals           │ 37.76 KB  │ 27.22 KB ║
+║ application          │ 12.88 KB  │ 7.57 KB  ║
+║ array                │ 12.68 KB  │ 7.33 KB  ║
+║ canary-features      │ 304 B     │ 419 B    ║
+║ component            │ 1.07 KB   │ 1016 B   ║
+║ controller           │ 1.87 KB   │ 1.38 KB  ║
+║ debug                │ 11.45 KB  │ 7.96 KB  ║
+║ deprecated-features  │ 31 B      │ 77 B     ║
+║ destroyable          │ 561 B     │ 383 B    ║
+║ enumerable           │ 307 B     │ 497 B    ║
+║ helper               │ 823 B     │ 581 B    ║
+║ instrumentation      │ 2.43 KB   │ 1.78 KB  ║
+║ modifier             │ 669 B     │ 621 B    ║
+║ object               │ 27.58 KB  │ 17.3 KB  ║
+║ owner                │ 159 B     │ 178 B    ║
+║ renderer             │ 406 B     │ 331 B    ║
+║ routing              │ 58.85 KB  │ 33.71 KB ║
+║ runloop              │ 2.2 KB    │ 1.34 KB  ║
+║ service              │ 859 B     │ 755 B    ║
+║ template             │ 430 B     │ 393 B    ║
+║ template-compilation │ 429 B     │ 366 B    ║
+║ template-compiler    │ 57.91 KB  │ 30.4 KB  ║
+║ template-factory     │ 94 B      │ 160 B    ║
+║ test                 │ 923 B     │ 627 B    ║
+║ utils                │ 3.99 KB   │ 3.53 KB  ║
+║ version              │ 55 B      │ 131 B    ║
+╚══════════════════════╧═══════════╧══════════╝
 
 ╔═════════════════╤═══════════╤══════════╗
 ║ @glimmer/*      │ Min       │ Gzip     ║
 ╟─────────────────┼───────────┼──────────╢
-║ Total           │ 179.25 KB │ 84.99 KB ║
+║ Total           │ 179.25 KB │ 85.02 KB ║
 ╟─────────────────┼───────────┼──────────╢
 ║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
 ║ encoder         │ 596 B     │ 653 B    ║
@@ -53,7 +53,7 @@
 ║ program         │ 7.1 KB    │ 3.63 KB  ║
 ║ reference       │ 5.51 KB   │ 3.18 KB  ║
 ║ runtime         │ 95.26 KB  │ 42.69 KB ║
-║ tracking        │ 989 B     │ 961 B    ║
+║ tracking        │ 989 B     │ 992 B    ║
 ║ util            │ 3.03 KB   │ 2.29 KB  ║
 ║ validator       │ 15.64 KB  │ 6.86 KB  ║
 ║ vm              │ 784 B     │ 798 B    ║

Details

This PRmain
╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 415.84 KB │ 230.92 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤══════════╗
║ @ember/*             │ Min       │ Gzip     ║
╟──────────────────────┼───────────┼──────────╢
║ Total                │ 236.59 KB │ 145.9 KB ║
╟──────────────────────┼───────────┼──────────╢
║ -internals           │ 37.76 KB  │ 27.22 KB ║
║ application          │ 12.88 KB  │ 7.57 KB  ║
║ array                │ 12.68 KB  │ 7.33 KB  ║
║ canary-features      │ 304 B     │ 419 B    ║
║ component            │ 1.07 KB   │ 1016 B   ║
║ controller           │ 1.87 KB   │ 1.38 KB  ║
║ debug                │ 11.45 KB  │ 7.96 KB  ║
║ deprecated-features  │ 31 B      │ 77 B     ║
║ destroyable          │ 561 B     │ 383 B    ║
║ enumerable           │ 307 B     │ 497 B    ║
║ helper               │ 823 B     │ 581 B    ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB  ║
║ modifier             │ 669 B     │ 621 B    ║
║ object               │ 27.58 KB  │ 17.3 KB  ║
║ owner                │ 159 B     │ 178 B    ║
║ renderer             │ 406 B     │ 331 B    ║
║ routing              │ 58.85 KB  │ 33.71 KB ║
║ runloop              │ 2.2 KB    │ 1.34 KB  ║
║ service              │ 859 B     │ 755 B    ║
║ template             │ 430 B     │ 393 B    ║
║ template-compilation │ 429 B     │ 366 B    ║
║ template-compiler    │ 57.91 KB  │ 30.4 KB  ║
║ template-factory     │ 94 B      │ 160 B    ║
║ test                 │ 923 B     │ 627 B    ║
║ utils                │ 3.99 KB   │ 3.53 KB  ║
║ version              │ 55 B      │ 131 B    ║
╚══════════════════════╧═══════════╧══════════╝

╔═════════════════╤═══════════╤══════════╗
║ @glimmer/*      │ Min       │ Gzip     ║
╟─────────────────┼───────────┼──────────╢
║ Total           │ 179.25 KB │ 85.02 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
║ encoder         │ 596 B     │ 653 B    ║
║ env             │ 38 B      │ 87 B     ║
║ global-context  │ 886 B     │ 545 B    ║
║ manager         │ 12.19 KB  │ 5.44 KB  ║
║ node            │ 2.71 KB   │ 1.81 KB  ║
║ opcode-compiler │ 29.89 KB  │ 13.23 KB ║
║ owner           │ 159 B     │ 202 B    ║
║ program         │ 7.1 KB    │ 3.63 KB  ║
║ reference       │ 5.51 KB   │ 3.18 KB  ║
║ runtime         │ 95.26 KB  │ 42.69 KB ║
║ tracking        │ 989 B     │ 992 B    ║
║ util            │ 3.03 KB   │ 2.29 KB  ║
║ validator       │ 15.64 KB  │ 6.86 KB  ║
║ vm              │ 784 B     │ 798 B    ║
║ wire-format     │ 1.84 KB   │ 1.35 KB  ║
╚═════════════════╧═══════════╧══════════╝
╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 418.65 KB │ 232.22 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤══════════╤═══════════╗
║ @ember/*             │ Min      │ Gzip      ║
╟──────────────────────┼──────────┼───────────╢
║ Total                │ 239.4 KB │ 147.23 KB ║
╟──────────────────────┼──────────┼───────────╢
║ -internals           │ 35.46 KB │ 25.49 KB  ║
║ application          │ 12.83 KB │ 7.7 KB    ║
║ array                │ 12.66 KB │ 7.32 KB   ║
║ canary-features      │ 304 B    │ 419 B     ║
║ component            │ 1.07 KB  │ 1005 B    ║
║ controller           │ 1.8 KB   │ 1.36 KB   ║
║ debug                │ 11.4 KB  │ 7.92 KB   ║
║ deprecated-features  │ 31 B     │ 77 B      ║
║ destroyable          │ 561 B    │ 383 B     ║
║ enumerable           │ 259 B    │ 387 B     ║
║ helper               │ 823 B    │ 605 B     ║
║ instrumentation      │ 2.43 KB  │ 1.78 KB   ║
║ modifier             │ 669 B    │ 581 B     ║
║ object               │ 33.78 KB │ 20.79 KB  ║
║ owner                │ 159 B    │ 178 B     ║
║ renderer             │ 406 B    │ 350 B     ║
║ routing              │ 58.08 KB │ 33.43 KB  ║
║ runloop              │ 2.2 KB   │ 1.33 KB   ║
║ service              │ 859 B    │ 741 B     ║
║ template             │ 430 B    │ 364 B     ║
║ template-compilation │ 429 B    │ 366 B     ║
║ template-compiler    │ 57.91 KB │ 30.4 KB   ║
║ template-factory     │ 94 B     │ 160 B     ║
║ test                 │ 923 B    │ 627 B     ║
║ utils                │ 3.93 KB  │ 3.5 KB    ║
║ version              │ 55 B     │ 131 B     ║
╚══════════════════════╧══════════╧═══════════╝

╔═════════════════╤═══════════╤══════════╗
║ @glimmer/*      │ Min       │ Gzip     ║
╟─────────────────┼───────────┼──────────╢
║ Total           │ 179.25 KB │ 84.99 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
║ encoder         │ 596 B     │ 653 B    ║
║ env             │ 38 B      │ 87 B     ║
║ global-context  │ 886 B     │ 545 B    ║
║ manager         │ 12.19 KB  │ 5.44 KB  ║
║ node            │ 2.71 KB   │ 1.81 KB  ║
║ opcode-compiler │ 29.89 KB  │ 13.23 KB ║
║ owner           │ 159 B     │ 202 B    ║
║ program         │ 7.1 KB    │ 3.63 KB  ║
║ reference       │ 5.51 KB   │ 3.18 KB  ║
║ runtime         │ 95.26 KB  │ 42.69 KB ║
║ tracking        │ 989 B     │ 961 B    ║
║ util            │ 3.03 KB   │ 2.29 KB  ║
║ validator       │ 15.64 KB  │ 6.86 KB  ║
║ vm              │ 784 B     │ 798 B    ║
║ wire-format     │ 1.84 KB   │ 1.35 KB  ║
╚═════════════════╧═══════════╧══════════╝

github-actions[bot] avatar Sep 05 '25 04:09 github-actions[bot]