ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

internal high-level testing (gjs, gts)?

Open NullVoxPopuli opened this issue 7 months ago • 5 comments

as a feature implementation person, I would like to have gjs and gts rendering tests, like what consuming apps have.

This may mean bringing in @ember/test-helpers in to this repo -- but I think this is a good thing. (I think we should do the same with @ember/test-waiters, too).

This way, it'll be way easier to provide reproduction issues for general things encountered by the community, as well as implement new features and starting with the end-user-style testing (basically: e2e).

If this already exists, and I missed it, lemme know <3

NullVoxPopuli avatar Jul 13 '25 20:07 NullVoxPopuli

Until we move to automated releasing https://github.com/emberjs/ember.js/issues/20759 I don't think it makes sense to move more packages into a monorepo here.

Until that time, more high-level tests can be achieved in the smoke-tests, either directly in the apps or in scenarios https://github.com/emberjs/ember.js/tree/main/smoke-tests/scenarios

kategengler avatar Aug 13 '25 03:08 kategengler

I think the smoke tests are sufficient here.

kategengler avatar Nov 25 '25 16:11 kategengler

naw, what I mean is our internal tests should use our nice authoring format, not the silly bespoke test infra we have all over the place

NullVoxPopuli avatar Nov 25 '25 17:11 NullVoxPopuli

You're going to need to share more details of what you mean.

kategengler avatar Nov 25 '25 17:11 kategengler

like, instead of:

this.renderComponent(ComponentClass, { template: '...' })

our tests should use all the nice stuff we implemented publicly:

await render(<template>
  <ComponentClass>
      ...
  </ComponentClass>
</template>);

NullVoxPopuli avatar Nov 25 '25 17:11 NullVoxPopuli