ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

Move us onto stable decorators

Open ef4 opened this issue 1 year ago • 6 comments

The recent build refactors should have made it easier now to run our tests under both legacy decorators and stable decorators. That would allow us to pick back up https://github.com/emberjs/ember.js/pull/20507

ef4 avatar Oct 15 '24 15:10 ef4

Much more progress in https://github.com/emberjs/ember.js/pull/20868

ef4 avatar Mar 11 '25 15:03 ef4

The next actions here are

  • update the PR to include typescript support for stable decorators and exercise it in a smokiest app.
  • write the RFC for how people should transition

ef4 avatar Mar 18 '25 15:03 ef4

Hi @ef4 @mansona, I’ve implemented the fix for this issue and opened PR #21012.
Whenever you get a moment, I’d appreciate a review and merge it.Thank you!

wcr-karan avatar Nov 25 '25 05:11 wcr-karan

@wcr-karan you did no such thing. please don't submit prs that delete a ton of our comments, or change our arrays apis.

NullVoxPopuli avatar Nov 25 '25 12:11 NullVoxPopuli

@NullVoxPopuli closed by mistake?

ro0gr avatar Nov 25 '25 15:11 ro0gr

yes! tyty I closed an AI generated PR, and I don't know why GH thought this was solved. Silly GH.

NullVoxPopuli avatar Nov 25 '25 16:11 NullVoxPopuli