ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

Upgrade to ember-cli-babel 8.2.0

Open NullVoxPopuli opened this issue 2 years ago • 6 comments

ember-cli-babel 8 includes nice things for supporting content-tag.

Ideally, however, once ember-source is a v2 addon, we can just remove ember-cli-babel.

The breaking change from ember-cli-babel 7 to 8: https://github.com/emberjs/ember-cli-babel/releases/tag/v8.0.0

is that the consuming project must have declared @babel/core, which is already in the blueprint: https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L29 (but was not added until ember-cli 5.3).

So, does this mean that ember-source can't upgrade ember-cli-babel? and instead should convert to v2 addon? (I'm thinking it does).

However, this needs finished, but I don't know what's going on anymore.

NullVoxPopuli avatar Oct 14 '23 18:10 NullVoxPopuli

Is this still relevant? It is a draft PR

kategengler avatar Dec 12 '23 16:12 kategengler

oh probably, I should rebase

NullVoxPopuli avatar Dec 12 '23 18:12 NullVoxPopuli

and convert from draft, if you want it merged :)

kategengler avatar Dec 12 '23 18:12 kategengler

Upgrade also happened over here: https://github.com/emberjs/ember.js/pull/20602/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L90

NullVoxPopuli avatar Dec 12 '23 20:12 NullVoxPopuli

Yeah, I am not sure what is the answer to your questions (basically: would it have been a breaking change if we required a new peer dependency?). I did write in my commit message that, if we couldn’t upgrade easily, I only needed the static block plugin so I could also configure that directly

chancancode avatar Dec 12 '23 23:12 chancancode

But if we are going to do that, feel free to land it here and I’ll rebase when it’s available. I don’t necessarily think that other branch is intended for direct merging anyway

chancancode avatar Dec 12 '23 23:12 chancancode